Repository navigation
be: tell transfers from card payments and filter by it, recorded live pending and booked - #43
Merged
Merged
Conversation
landsman
marked this pull request as draft
November 7, 2026 18:19
Owner
Author
|
Read live on 2026-11-09 (Monday) at 17:17: the card payment is still |
…ded once the hold was booked
landsman
force-pushed
the
be/card-payments
branch
from
November 10, 2026 13:48
bfa9434 to
d95068d
Compare
landsman
marked this pull request as ready for review
November 10, 2026 13:58
5 tasks
… app passes no id
…ncluded, not only merchants
…each java example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A card payment was read live, pending on 2026-11-07 and booked on 2026-11-10, and the client now says how each movement was made and filters by it:
Transaction.method()isTRANSFER,CARDorOTHER, read fromclearingSystemReferencewith theBLOCKED_prefix a pending movement carries dropped.OTHERcovers fees, interest, ATM withdrawals and whatever else has not been seen live yet: #66. The query is immutable and reads nothing untillist(); onlybetweenis required, the rest is optional, and since MONETA filters by date only, it reads the whole range and drops the rest in the client.Both card payments are recorded:
live/pending-card.json(account, reference and merchant replaced) andlive/booked-card.json(account and symbols replaced; the card number, already masked by MONETA, and the merchant kept)..docs/moneta-api.mdsets them side by side.What booking changed:
creditor.name(40 characters at fixed widths) totransactionDescription(30 characters, a different text), socounterpartyName()falls back to the description for a card payment;chequeNumber),PLATBA KARTOU ONLINEand a purpose; not mapped.methodis a newTransactioncomponent beforeraw, which the docs allow before 1.0; the café's tests construct it and got the extra argument. The README's "Card transactions" row stays unticked: that is MONETA's own card endpoint, behind the portal.Without an account id, the holder reads the only account the token opens, once, and remembers it, so a poller keeping the holder makes no extra request; a token with several accounts is refused.
.docs/usage.mdis cut to what a caller needs, with a collapsed Kotlin version under each Java example.Checked:
make buildgreen; tests for the pending and the booked card payment, booked transfers, and the query (each step, a replaced step, a card payment, no dates refused before any request, the only account read once per holder, a token with two refused). The Java and Kotlin doc examples compile against the built jar.Still open, for later: